Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding environment testing and short version to nb adding instructions #71

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

rmshkv
Copy link
Contributor

@rmshkv rmshkv commented Feb 28, 2024

I added a step telling people to install the cupid-analysis environment and test there. I also noted where people can stop if they don't want to fully run the notebook with CUPiD themselves yet, so they can pass it along to us at that point instead.

Addresses #70.

…uctions

I added a step telling people to install the cupid-analysis environment and test there. I also noted where people can stop if they don't want to fully run the notebook with CUPiD themselves yet, so they can pass it along to us at that point instead.
@rmshkv rmshkv requested a review from mnlevy1981 February 28, 2024 21:55
docs/addingnotebookstocollection.md Show resolved Hide resolved
docs/addingnotebookstocollection.md Show resolved Hide resolved
docs/addingnotebookstocollection.md Outdated Show resolved Hide resolved
@rmshkv rmshkv requested a review from mnlevy1981 February 29, 2024 20:33
Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mnlevy1981 mnlevy1981 linked an issue Feb 29, 2024 that may be closed by this pull request
@rmshkv rmshkv merged commit 2ff8a8e into main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update adding notebooks instructions
2 participants